Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undo RenderingEntities inline initialization #2374

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Arufonsu
Copy link
Contributor

@Arufonsu Arufonsu commented Aug 7, 2024

Fixes RenderingEntities inline initialization crashing the client when using custom map width/height

(We merged this breaking change here)

crash log (when changing MapWidth/MapHeight to 64x64):

--------------------------------------------------------------------------------
2024-08-07 14:18:25.906 [Error] IndexOutOfRangeException: Index was outside the bounds of the array.
    Stack:    at Intersect.Client.Core.Graphics.InitInGame() in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\Core\Graphics.cs:line 142
   at Intersect.Client.Networking.PacketHandler.HandlePacket(IPacketSender packetSender, ConfigPacket packet) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\Networking\PacketHandler.cs:line 180
   at Intersect.Network.PacketHandlerRegistry.<>c__DisplayClass38_1`2.<CreateWeaklyTypedDelegateForMethodInfo>b__1(IPacketSender packetSender, IPacket packet) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect (Core)\Network\PacketHandlerRegistry.cs:line 98
   at Intersect.Client.Networking.PacketHandler.HandlePacket(IPacket packet) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\Networking\PacketHandler.cs:line 134
   at Intersect.Client.Networking.Network.OnDataReceived(IPacket packet) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\Networking\Network.cs:line 122
   at Intersect.Client.MonoGame.Network.MonoSocket.Update() in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\MonoGame\Network\MonoSocket.cs:line 262
   at Intersect.Client.Core.Main.Update(TimeSpan deltaTime) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\Core\Main.cs:line 103
   at Intersect.Client.MonoGame.IntersectGame.Update(GameTime gameTime) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\MonoGame\IntersectGame.cs:line 280
   at Microsoft.Xna.Framework.Game.DoUpdate(GameTime gameTime)
   at Microsoft.Xna.Framework.Game.Tick()
   at Microsoft.Xna.Framework.SdlGamePlatform.RunLoop()
   at Microsoft.Xna.Framework.Game.Run(GameRunBehavior runBehavior)
   at Microsoft.Xna.Framework.Game.Run()
   at Intersect.Client.MonoGame.IntersectGame.MonoGameRunner.Start(IClientContext context, Action postStartupAction) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\MonoGame\IntersectGame.cs:line 562
   at Intersect.Client.Core.ClientContext.InternalStart() in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect.Client\Core\ClientContext.cs:line 41
   at Intersect.Core.ApplicationContext`2.Start(Boolean lockUntilShutdown) in C:\Users\Admin\Desktop\VSCode\Intersect-Engine\Intersect (Core)\Core\ApplicationContext`2.cs:line 231


--------------------------------------------------------------------------------

fixes RenderingEntities inline initialization crashing the client when using custom map width/height
@Arufonsu Arufonsu added the bug fix Pull request that fixes a bug label Aug 7, 2024
@Arufonsu Arufonsu requested review from a team August 7, 2024 17:14
@lodicolo lodicolo merged commit 447809f into main Aug 7, 2024
1 check passed
@lodicolo lodicolo deleted the fix/RenderingEntitiesInLineInitCrash branch August 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants